Will me and my amazing insecure libra guy work?

I am a 18 year old cancer and he is a 20 year old libra. We have been together for one year. The first few months were great and interesting. Now he is extremely insecure and so straight forward with his thoughts. i love him to death.when I'm with him i feel safe and beautiful. I don't feel like he appreciates me and the handwork i put into this relationship. We always argue and he is always telling me what he doesn't like about me. Then on the other hand he its deeply in love me and loves to hold me in his arms every night. He can be so cold and unresponsive sometimes but i can't help but brush it off and keep trying to make it work. He expects for me to tell him everything every secret every past relationship everything that goes on in my day. I often ask myself why am i here but i remember everytime i look into his eyes and he puts his arms around me. He is always quesioning my loyalty but surprisingly always willing to make it work. I love and adore him but will my hard work pay off or will i be left sad and heart broken in the end?

Thanks. He is a great guy and so lovable i really want this to work. He worrys his mnd crazy about me. i just wish he could relax and believe that this us not too good to be true. I am relatshionship material and this is the first guy i have claim to be in love with. You dont see a future in this relationship?